Add transpose ops make convolutions channels-last. #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into pytorch:main from hsharma35:export-D62484686

Oct 25, 2024

+22 −5

Contributor

hsharma35 commented Oct 23, 2024

Summary: Keeping this pass at opt_level=3 as this would introduce extra transpose ops.

Reviewed By: zonglinpeng

Differential Revision: D62484686

pytorch-bot bot commented Oct 23, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6459

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ac73b60 with merge base 395b4d6 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Oct 23, 2024

This pull request was exported from Phabricator. Differential Revision: D62484686

facebook-github-bot added the fb-exported label

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459

c919152

)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686

hsharma35 force-pushed the export-D62484686 branch from cc1d656 to c919152 Compare

October 23, 2024 17:33

Contributor

facebook-github-bot commented Oct 23, 2024

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459

8793f92

)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686

hsharma35 force-pushed the export-D62484686 branch from c919152 to 8793f92 Compare

October 23, 2024 18:38

Contributor

facebook-github-bot commented Oct 23, 2024

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 force-pushed the export-D62484686 branch from 8793f92 to 97c4095 Compare

October 24, 2024 17:22

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459

97c4095

)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686

Contributor

facebook-github-bot commented Oct 24, 2024

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459

7c54d06

)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686

hsharma35 force-pushed the export-D62484686 branch from 97c4095 to 7c54d06 Compare

October 24, 2024 17:29

Contributor

facebook-github-bot commented Oct 24, 2024

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459

674b8b7

)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686

hsharma35 force-pushed the export-D62484686 branch from 7c54d06 to 674b8b7 Compare

October 24, 2024 18:59

Contributor

facebook-github-bot commented Oct 24, 2024

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459

a7d774a

)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686

hsharma35 force-pushed the export-D62484686 branch from 674b8b7 to a7d774a Compare

October 24, 2024 19:37

Contributor

facebook-github-bot commented Oct 24, 2024

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459

43a0c9c

)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686

hsharma35 force-pushed the export-D62484686 branch from a7d774a to 43a0c9c Compare

October 24, 2024 19:37

Contributor

facebook-github-bot commented Oct 24, 2024

This pull request was exported from Phabricator. Differential Revision: D62484686

zonglinpeng approved these changes

View reviewed changes


          Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459

ac73b60

)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686

hsharma35 force-pushed the export-D62484686 branch from 43a0c9c to ac73b60 Compare

October 24, 2024 20:23

Contributor

facebook-github-bot commented Oct 24, 2024

This pull request was exported from Phabricator. Differential Revision: D62484686

facebook-github-bot merged commit e93ad5f into pytorch:main

46 of 48 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported